| Date | Fri, 19 Jul 2019 19:03:31 +0900 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH AUTOSEL 5.2 014/171] consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c |
| |
On Thu, Jul 18, 2019 at 11:54:05PM -0400, Sasha Levin wrote: > From: Gen Zhang <blackgod016574@gmail.com> > > [ Upstream commit 84ecc2f6eb1cb12e6d44818f94fa49b50f06e6ac ] > > In function con_insert_unipair(), when allocation for p2 and p1[n] > fails, ENOMEM is returned, but previously allocated p1 is not freed, > remains as leaking memory. Thus we should free p1 as well when this > allocation fails. > > Signed-off-by: Gen Zhang <blackgod016574@gmail.com> > Reviewed-by: Kees Cook <keescook@chromium.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/tty/vt/consolemap.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-)
No, please do not take this patch, it was reverted in commit 15b3cd8ef46a ("Revert "consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c"") because it was broken.
Please drop from all of the autosel queues.
thanks,
greg k-h
|