lkml.org 
[lkml]   [2019]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal
    On Thu, 18 Jul 2019 08:26:11 -0400 "Michael S. Tsirkin" <mst@redhat.com> wrote:

    > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote:
    > > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces)
    > >
    > > A #GP is reported in the guest when requesting balloon inflation via
    > > virtio-balloon. The reason is that the virtio-balloon driver has
    > > removed the page from its internal page list (via balloon_page_pop),
    > > but balloon_page_enqueue_one also calls "list_del" to do the removal.
    > > This is necessary when it's used from balloon_page_enqueue_list, but
    > > not from balloon_page_enqueue_one.
    > >
    > > So remove the list_del balloon_page_enqueue_one, and update some
    > > comments as a reminder.
    > >
    > > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
    >
    >
    > ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. Pls take a look.

    I really have no idea what you're talking about here :(. Some other
    discussion and patch thread, I suppose.

    You're OK with this patch?

    Should this patch have cc:stable?

    \
     
     \ /
      Last update: 2019-07-18 22:36    [W:3.951 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site