Messages in this thread Patch in this message | | | From | Saeed Mahameed <> | Subject | Re: [PATCH v2] net/mlx5: Replace kfree with kvfree | Date | Thu, 18 Jul 2019 18:38:34 +0000 |
| |
On Wed, 2019-07-17 at 18:14 +0800, Chuhong Yuan wrote: > Variable allocated by kvmalloc should not be freed by kfree. > Because it may be allocated by vmalloc. > So replace kfree with kvfree here. > > Fixes: 9b1f298236057 ("net/mlx5: Add support for FW fatal reporter > dump") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Dave, i guess this can go to net.
Thanks, Saeed.
> --- > Changes in v2: > - Add corresponding Fixes tag > > drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c > b/drivers/net/ethernet/mellanox/mlx5/core/health.c > index 2fe6923f7ce0..9314777d99e3 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c > @@ -597,7 +597,7 @@ mlx5_fw_fatal_reporter_dump(struct > devlink_health_reporter *reporter, > err = devlink_fmsg_arr_pair_nest_end(fmsg); > > free_data: > - kfree(cr_data); > + kvfree(cr_data); > return err; > } >
| |