lkml.org 
[lkml]   [2019]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4][V2] drivers: spi: core: Add optional delay between cs_change transfers
    On Wed, Jul 17, 2019 at 02:51:06PM +0300, Alexandru Ardelean wrote:
    > Some devices like the ADIS16460 IMU require a stall period between
    > transfers, i.e. between when the CS is de-asserted and re-asserted. The
    > default value of 10us is not enough. This change makes the delay
    > configurable for when the next CS change goes active.

    To repeat my previous feedback:

    | This looks like cs_change_delay.

    Please use subject lines matching the style for the subsystem. This
    makes it easier for people to identify relevant patches.

    Please don't ignore review comments, people are generally making them
    for a reason and are likely to have the same concerns if issues remain
    unaddressed. Having to repeat the same comments can get repetitive and
    make people question the value of time spent reviewing. If you disagree
    with the review comments that's fine but you need to reply and discuss
    your concerns so that the reviewer can understand your decisions.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-07-18 14:50    [W:3.568 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site