Messages in this thread | | | Date | Thu, 18 Jul 2019 10:44:45 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 2/3] x86/mm: Sync also unmappings in vmalloc_sync_one() |
| |
Hi Dave,
On Wed, Jul 17, 2019 at 02:06:01PM -0700, Dave Hansen wrote: > On 7/17/19 12:14 AM, Joerg Roedel wrote: > > - if (!pmd_present(*pmd)) > > + if (pmd_present(*pmd) ^ pmd_present(*pmd_k)) > > set_pmd(pmd, *pmd_k); > > Wouldn't: > > if (pmd_present(*pmd) != pmd_present(*pmd_k)) > set_pmd(pmd, *pmd_k); > > be a bit more intuitive?
Yes, right. That is much better, I changed it in the patch.
> But, either way, these look fine. For the series: > > Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
Thanks!
Joerg
| |