lkml.org 
[lkml]   [2019]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] x86/mm: Sync also unmappings in vmalloc_sync_one()
Hi Dave,

On Wed, Jul 17, 2019 at 02:06:01PM -0700, Dave Hansen wrote:
> On 7/17/19 12:14 AM, Joerg Roedel wrote:
> > - if (!pmd_present(*pmd))
> > + if (pmd_present(*pmd) ^ pmd_present(*pmd_k))
> > set_pmd(pmd, *pmd_k);
>
> Wouldn't:
>
> if (pmd_present(*pmd) != pmd_present(*pmd_k))
> set_pmd(pmd, *pmd_k);
>
> be a bit more intuitive?

Yes, right. That is much better, I changed it in the patch.

> But, either way, these look fine. For the series:
>
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>

Thanks!


Joerg

\
 
 \ /
  Last update: 2019-07-18 10:45    [W:0.069 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site