lkml.org 
[lkml]   [2019]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [EXT] [PATCH] qed: Prefer pcie_capability_read_word()
    Date
    > From: Frederick Lawler <fred@fredlawl.com>
    > Sent: Thursday, July 18, 2019 5:08 AM
    >
    > External Email
    >
    > ----------------------------------------------------------------------
    > Commit 8c0d3a02c130 ("PCI: Add accessors for PCI Express Capability") added
    > accessors for the PCI Express Capability so that drivers didn't need to be
    > aware of differences between v1 and v2 of the PCI Express Capability.
    >
    > Replace pci_read_config_word() and pci_write_config_word() calls with
    > pcie_capability_read_word() and pcie_capability_write_word().
    >
    > Signed-off-by: Frederick Lawler <fred@fredlawl.com>
    > ---
    > drivers/net/ethernet/qlogic/qed/qed_rdma.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
    > b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
    > index 7873d6dfd91f..8d8a920c3195 100644
    > --- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
    > +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
    > @@ -530,9 +530,8 @@ static void qed_rdma_init_devinfo(struct qed_hwfn
    > *p_hwfn,
    > SET_FIELD(dev->dev_caps,
    > QED_RDMA_DEV_CAP_LOCAL_INV_FENCE, 1);
    >
    > /* Check atomic operations support in PCI configuration space. */
    > - pci_read_config_dword(cdev->pdev,
    > - cdev->pdev->pcie_cap + PCI_EXP_DEVCTL2,
    > - &pci_status_control);
    > + pcie_capability_read_dword(cdev->pdev, PCI_EXP_DEVCTL2,
    > + &pci_status_control);
    >
    > if (pci_status_control & PCI_EXP_DEVCTL2_LTR_EN)
    > SET_FIELD(dev->dev_caps,
    > QED_RDMA_DEV_CAP_ATOMIC_OP, 1);
    > --
    > 2.17.1

    Thanks, 

    Acked-by: Michal Kalderon <michal.kalderon@marvell.com>


    \
     
     \ /
      Last update: 2019-07-18 10:22    [W:3.193 / U:0.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site