Messages in this thread | | | From | Dan Williams <> | Date | Wed, 17 Jul 2019 11:45:05 -0700 | Subject | Re: [PATCH v2 2/2] mm,memory_hotplug: Fix shrink_{zone,node}_span |
| |
On Wed, Jul 17, 2019 at 2:07 AM Oscar Salvador <osalvador@suse.de> wrote: > > Since [1], shrink_{zone,node}_span work on PAGES_PER_SUBSECTION granularity. > We need to adapt the loop that checks whether a zone/node contains only holes, > and skip the whole range to be removed. > > Otherwise, since sub-sections belonging to the range to be removed have not yet > been deactivated, pfn_valid() will return true on those and we will be left > with a wrong accounting of spanned_pages, both for the zone and the node. > > Fixes: mmotm ("mm/hotplug: prepare shrink_{zone, pgdat}_span for sub-section removal") > Signed-off-by: Oscar Salvador <osalvador@suse.de>
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
| |