Messages in this thread | | | Date | Tue, 16 Jul 2019 11:50:32 +0100 | From | Daniel Thompson <> | Subject | Re: [PATCH v2 2/2] leds: Add control of the voltage/current regulator to the LED core |
| |
On Mon, Jul 15, 2019 at 05:56:57PM +0200, Jean-Jacques Hiblot wrote: > A LED is usually powered by a voltage/current regulator. Let the LED core
This is almost certainly nitpicking but since there's enough other review comments that you will have to respin anyway ;-)
Is an LED really "usually powered by a voltage/current regulator"? Some LEDs have a software controlled power supply but I'm not sure it is the usual case.
Likewise its a little confusing to be talking about LEDs with an external current regulator since, although that is possible, it is also one the main features provided by LED driver chips.
Daniel.
| |