lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.1 204/219] Bluetooth: hci_bcsp: Fix memory leak in rx_skb
    Date
    From: Tomas Bortoli <tomasbortoli@gmail.com>

    [ Upstream commit 4ce9146e0370fcd573f0372d9b4e5a211112567c ]

    Syzkaller found that it is possible to provoke a memory leak by
    never freeing rx_skb in struct bcsp_struct.

    Fix by freeing in bcsp_close()

    Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
    Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bluetooth/hci_bcsp.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
    index 1a7f0c82fb36..66fe1e6dc631 100644
    --- a/drivers/bluetooth/hci_bcsp.c
    +++ b/drivers/bluetooth/hci_bcsp.c
    @@ -759,6 +759,11 @@ static int bcsp_close(struct hci_uart *hu)
    skb_queue_purge(&bcsp->rel);
    skb_queue_purge(&bcsp->unrel);

    + if (bcsp->rx_skb) {
    + kfree_skb(bcsp->rx_skb);
    + bcsp->rx_skb = NULL;
    + }
    +
    kfree(bcsp);
    return 0;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 17:45    [W:4.086 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site