lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.2 170/249] clocksource/drivers/tegra: Release all IRQ's on request_irq() error
    Date
    From: Dmitry Osipenko <digetx@gmail.com>

    [ Upstream commit 7a3916706e858ad0bc3b5629c68168e1449de26a ]

    Release all requested IRQ's on the request error to properly clean up
    allocated resources.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    Acked-By: Peter De Schrijver <pdeschrijver@nvidia.com>
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clocksource/timer-tegra20.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/clocksource/timer-tegra20.c b/drivers/clocksource/timer-tegra20.c
    index 1e7ece279730..fe5cc0963ac9 100644
    --- a/drivers/clocksource/timer-tegra20.c
    +++ b/drivers/clocksource/timer-tegra20.c
    @@ -288,7 +288,7 @@ static int __init tegra_init_timer(struct device_node *np)
    pr_err("%s: can't map IRQ for CPU%d\n",
    __func__, cpu);
    ret = -EINVAL;
    - goto out;
    + goto out_irq;
    }

    irq_set_status_flags(cpu_to->clkevt.irq, IRQ_NOAUTOEN);
    @@ -298,7 +298,8 @@ static int __init tegra_init_timer(struct device_node *np)
    if (ret) {
    pr_err("%s: cannot setup irq %d for CPU%d\n",
    __func__, cpu_to->clkevt.irq, cpu);
    - ret = -EINVAL;
    + irq_dispose_mapping(cpu_to->clkevt.irq);
    + cpu_to->clkevt.irq = 0;
    goto out_irq;
    }
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 17:15    [W:3.508 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site