lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.2 090/249] gpio: omap: fix lack of irqstatus_raw0 for OMAP4
    Date
    From: Russell King <rmk+kernel@armlinux.org.uk>

    [ Upstream commit 64ea3e9094a1f13b96c33244a3fb3a0f45690bd2 ]

    Commit 384ebe1c2849 ("gpio/omap: Add DT support to GPIO driver") added
    the register definition tables to the gpio-omap driver. Subsequently to
    that commit, commit 4e962e8998cc ("gpio/omap: remove cpu_is_omapxxxx()
    checks from *_runtime_resume()") added definitions for irqstatus_raw*
    registers to the legacy OMAP4 definitions, but missed the DT
    definitions.

    This causes an unintentional change of behaviour for the 1.101 errata
    workaround on OMAP4 platforms. Fix this oversight.

    Fixes: 4e962e8998cc ("gpio/omap: remove cpu_is_omapxxxx() checks from *_runtime_resume()")
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
    Tested-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/gpio-omap.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
    index 9276ef616430..7632c98aa3a4 100644
    --- a/drivers/gpio/gpio-omap.c
    +++ b/drivers/gpio/gpio-omap.c
    @@ -1453,6 +1453,8 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = {
    .clr_dataout = OMAP4_GPIO_CLEARDATAOUT,
    .irqstatus = OMAP4_GPIO_IRQSTATUS0,
    .irqstatus2 = OMAP4_GPIO_IRQSTATUS1,
    + .irqstatus_raw0 = OMAP4_GPIO_IRQSTATUSRAW0,
    + .irqstatus_raw1 = OMAP4_GPIO_IRQSTATUSRAW1,
    .irqenable = OMAP4_GPIO_IRQSTATUSSET0,
    .irqenable2 = OMAP4_GPIO_IRQSTATUSSET1,
    .set_irqenable = OMAP4_GPIO_IRQSTATUSSET0,
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 16:15    [W:2.297 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site