lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.2 123/249] tools build: Fix the zstd test in the test-all.c common case feature test
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    [ Upstream commit 3469fa84c1631face938efc42b3f488a2c2504e0 ]

    We were renanimg 'main' to 'main_zstd' but then using 'main_libzstd();'
    in the main() for test-all.c, causing this:

    $ cat /tmp/build/perf/feature/test-all.make.output
    test-all.c: In function ‘main’:
    test-all.c:236:2: error: implicit declaration of function ‘main_test_libzstd’; did you mean ‘main_test_zstd’? [-Werror=implicit-function-declaration]
    main_test_libzstd();
    ^~~~~~~~~~~~~~~~~
    main_test_zstd
    cc1: all warnings being treated as errors
    $

    I.e. what was supposed to be the fast path feature test was _always_
    failing, duh, fix it.

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
    Fixes: 3b1c5d965971 ("tools build: Implement libzstd feature check, LIBZSTD_DIR and NO_LIBZSTD defines")
    Link: https://lkml.kernel.org/n/tip-ma4abk0utroiw4mwpmvnjlru@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/build/feature/test-all.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
    index a59c53705093..939ac2fcc783 100644
    --- a/tools/build/feature/test-all.c
    +++ b/tools/build/feature/test-all.c
    @@ -182,7 +182,7 @@
    # include "test-disassembler-four-args.c"
    #undef main

    -#define main main_test_zstd
    +#define main main_test_libzstd
    # include "test-libzstd.c"
    #undef main

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 16:15    [W:4.357 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site