Messages in this thread | | | Subject | Re: [PATCH 04/22] x86/kvm: Don't call kvm_spurious_fault() from .fixup | From | Paolo Bonzini <> | Date | Mon, 15 Jul 2019 15:05:33 +0200 |
| |
On 15/07/19 14:40, Josh Poimboeuf wrote: >>> * Hardware virtualization extension instructions may fault if a >>> * reboot turns off virtualization while processes are running. >>> - * Trap the fault and ignore the instruction if that happens. >>> + * If that happens, trap the fault and panic (unless we're rebooting). >> Not sure the comment is better than before, but apar from that > The previous comment didn't seem to match the code, since we only ignore > the instruction if we're rebooting. >
"If that happens" refers to "a reboot turns off virtualization while processes are running". Perhaps
* Usually after catching the fault we just panic; during reboot * instead the instruction is ignored.
Paolo
| |