lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source
Date
> Caution: EXT Email
>
> On 15/07/2019 18:15:19+0800, Biwen Li wrote:
> > + device_init_wakeup(&pdev->dev, true);
> > + rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, "ftm-alarm",
> > +
> &ftm_rtc_ops,
> > +
> THIS_MODULE);
>
> To be clear, I want you to not use devm_rtc_device_register and use
> devm_rtc_allocate_device and rtc_register_device.
I will correct it in v5.
>
> > + if (IS_ERR(rtc->rtc_dev)) {
> > + dev_err(&pdev->dev, "can't register rtc device\n");
> > + return PTR_ERR(rtc->rtc_dev);
> > + }
> > +
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.
> com&data=02%7C01%7Cbiwen.li%40nxp.com%7Cc5b1382ed1fb493cf69
> f08d7093513b2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 6987995881848030&sdata=T71z2Rjw%2FZL444U8C1ow3WcoyDYl76Mq
> niLIupXbXtI%3D&reserved=0

\
 
 \ /
  Last update: 2019-07-16 05:49    [W:0.033 / U:2.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site