Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH v3 20/24] wireless: Remove call to memset after dma_alloc_coherent | Date | Mon, 15 Jul 2019 12:07:56 +0300 |
| |
Fuqian Huang <huangfq.daxian@gmail.com> writes:
> In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> > --- > Changes in v3: > - Use actual commit rather than the merge commit in the commit message > > drivers/net/wireless/ath/ath10k/ce.c | 5 ----- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 -- > drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 -- > drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 -- > 4 files changed, 11 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c > index eca87f7c5b6c..294fbc1e89ab 100644 > --- a/drivers/net/wireless/ath/ath10k/ce.c > +++ b/drivers/net/wireless/ath/ath10k/ce.c > @@ -1704,9 +1704,6 @@ ath10k_ce_alloc_dest_ring_64(struct ath10k *ar, unsigned int ce_id, > /* Correctly initialize memory to 0 to prevent garbage > * data crashing system when download firmware > */ > - memset(dest_ring->base_addr_owner_space_unaligned, 0, > - nentries * sizeof(struct ce_desc_64) + CE_DESC_RING_ALIGN);
Shouldn't you also remove the comment?
-- Kalle Valo
| |