Messages in this thread | | | Date | Mon, 15 Jul 2019 17:08:07 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] clocksource/drivers/npcm: fix GENMASK and timer operation |
| |
Avi,
On Mon, 15 Jul 2019, Avi Fishman wrote: > On Mon, Jul 15, 2019 at 3:37 PM Thomas Gleixner <tglx@linutronix.de> wrote: > > 9bdd7bb3a844 ("clocksource/drivers/npcm: Fix misuse of GENMASK macro") > > The automatic fix changed from > GENMASK(3, 27) to > GENMASK(27, 3) > I reviewd again the code to check how it worked so far and saw that it > should have been > GENMASK(28, 27) - this is a different value than 9bdd7bb3a844 > For our fortune this wrong value didn't effect the our final write to > the register. > But still this should be fixed.
Fair enough. Please explain it proper in the changelog.
Thanks,
tglx
| |