Messages in this thread | | | Subject | Re: [PATCH v3 15/24] media: exynos4-is: Remove call to memset after dma_alloc_coherent | From | Sylwester Nawrocki <> | Date | Mon, 15 Jul 2019 11:01:21 +0200 |
| |
On 7/15/19 05:18, Fuqian Huang wrote: > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed
I can't see any changes in the above mentioned commit that would make dma_alloc_coherent() (arm_coherent_dma_alloc()) zeroing its returned memory. Maybe you need to add a reference to some other instead?
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> drivers/media/platform/exynos4-is/fimc-is.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c > index e043d55133a3..77633e356305 100644 > --- a/drivers/media/platform/exynos4-is/fimc-is.c > +++ b/drivers/media/platform/exynos4-is/fimc-is.c > @@ -341,7 +341,6 @@ static int fimc_is_alloc_cpu_memory(struct fimc_is *is) > return -ENOMEM; > > is->memory.size = FIMC_IS_CPU_MEM_SIZE; > - memset(is->memory.vaddr, 0, is->memory.size); -- Thanks, Sylwester
| |