Messages in this thread | | | Date | Sat, 13 Jul 2019 09:26:03 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nvmet-file: fix nvmet_file_flush() always returning an error |
| |
On Fri, Jul 12, 2019 at 04:42:07PM -0600, Logan Gunthorpe wrote: > errno_to_nvme_status() doesn't take into account the case > when errno=0, all other use cases only call it if there is actually > an error.
Might it make more sense to handle 0 in errno_to_nvme_status to avoid future problems like this one as well? That would also match the similar blk_to_nvme_status function better.
| |