Messages in this thread | | | From | Masahiro Yamada <> | Date | Sun, 14 Jul 2019 08:37:56 +0900 | Subject | Re: [PATCH v2] jffs2: remove C++ style comments from uapi header |
| |
On Thu, Jun 27, 2019 at 4:39 PM Richard Weinberger <richard@nod.at> wrote: > > ----- Ursprüngliche Mail ----- > > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > > An: "richard" <richard@nod.at> > > CC: "Vignesh Raghavendra" <vigneshr@ti.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "linux-kernel" > > <linux-kernel@vger.kernel.org>, "Marek Vasut" <marek.vasut@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, > > "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" <computersforpeace@gmail.com>, "David Woodhouse" > > <dwmw2@infradead.org> > > Gesendet: Donnerstag, 27. Juni 2019 09:06:31 > > Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header > > > On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote: > >> > >> ----- Ursprüngliche Mail ----- > >> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > >> > An: "linux-mtd" <linux-mtd@lists.infradead.org> > >> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" > >> > <miquel.raynal@bootlin.com>, "Brian Norris" > >> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek > >> > Vasut" <marek.vasut@gmail.com>, > >> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, > >> > "David Woodhouse" <dwmw2@infradead.org>, > >> > "linux-kernel" <linux-kernel@vger.kernel.org> > >> > Gesendet: Dienstag, 18. Juni 2019 05:09:26 > >> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header > >> > >> > Linux kernel tolerates C++ style comments these days. Actually, the > >> > SPDX License tags for .c files start with //. > >> > > >> > On the other hand, uapi headers are written in more strict C, where > >> > the C++ comment style is forbidden. > >> > > >> > I simply dropped these lines instead of fixing the comment style. > >> > > >> > This code has been always commented out since it was added around > >> > Linux 2.4.9 (i.e. commented out for more than 17 years). > >> > > >> > 'Maybe later...' will never happen. > >> > >> :-) > >> > >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > >> > >> Acked-by: Richard Weinberger <richard@nod.at> > >> > >> Thanks, > >> //richard > > > > > > Will this be picked up for v5.3-rc1 ? > > Yes. > > Thanks, > //richard
Looks like this trivial patch missed the pull request.
My motivation is to make sure UAPI headers are really compilable in user-space, and now checked by the following commit:
commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85 Author: Masahiro Yamada <yamada.masahiro@socionext.com> Date: Mon Jul 1 09:58:40 2019 +0900
kbuild: compile-test exported headers to ensure they are self-contained
Is there a chance for it being merged, or must wait until v5.4-rc1 ?
-- Best Regards Masahiro Yamada
| |