Messages in this thread | | | Subject | Re: [PATCH] soc: ti: fix irq-ti-sci link error | From | santosh.shilimkar@oracle ... | Date | Mon, 1 Jul 2019 18:30:09 -0700 |
| |
On 7/1/19 3:24 PM, Olof Johansson wrote: > On Mon, Jul 1, 2019 at 10:36 AM <santosh.shilimkar@oracle.com> wrote: >> >> On 6/17/19 6:01 AM, Arnd Bergmann wrote: >>> The irqchip driver depends on the SoC specific driver, but we want >>> to be able to compile-test it elsewhere: >>> >>> WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN >>> Depends on [n]: SOC_TI [=n] >>> Selected by [y]: >>> - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] >>> >>> drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': >>> irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' >>> >>> Rearrange the Kconfig and Makefile so we build the soc driver whenever >>> its users are there, regardless of the SOC_TI option. >>> >>> Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") >>> Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >>> --- >> Thanks Arnd. Will you be able to add it to your fixes queue. >> >> FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org> > > Cc:ing to arm@kernel.org is the best way to make sure it surfaces. > > Also, please do Acked-by on separate line so the tools catch it next Will do..
> time (also, check for typos. :) > :- )
> Applying to fixes. Thanks for picking it up.
| |