Messages in this thread | | | From | Rob Clark <> | Date | Mon, 1 Jul 2019 12:45:38 -0700 | Subject | Re: [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space |
| |
On Mon, Jul 1, 2019 at 10:39 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > Creating the msm gem address space requires a reference to the dev where > the iommu is located. The driver currently assumes this is the same as > the platform device, which breaks when the iommu is outside of the > platform device. Use the drm_device instead, which happens to always have > a reference to the proper device. > > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index 4a60f5fca6b0..1347a5223918 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -702,7 +702,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) > mdelay(16); > > if (config->platform.iommu) { > - aspace = msm_gem_address_space_create(&pdev->dev, > + aspace = msm_gem_address_space_create(dev->dev, > config->platform.iommu, "mdp5");
hmm, do you have a tree somewhere with your dt files? This makes me think the display iommu is hooked up somewhere differently compared to, say, msm8916.dtsi
BR, -R
> if (IS_ERR(aspace)) { > ret = PTR_ERR(aspace); > -- > 2.17.1 >
| |