Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 9 Jun 2019 23:50:21 +0200 | Subject | Re: [RFC next v1 3/5] net: stmmac: use GPIO descriptors in stmmac_mdio_reset |
| |
On Sun, Jun 9, 2019 at 8:06 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Switch stmmac_mdio_reset to use GPIO descriptors. GPIO core handles the > "snps,reset-gpio" for GPIO descriptors so we don't need to take care of > it inside the driver anymore. > > The advantage of this is that we now preserve the GPIO flags which are > passed via devicetree. This is required on some newer Amlogic boards > which use an Open Drain pin for the reset GPIO. This pin can only output > a LOW signal or switch to input mode but it cannot output a HIGH signal. > There are already devicetree bindings for these special cases and GPIO > core already takes care of them but only if we use GPIO descriptors > instead of GPIO numbers. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
This is in line with how I want the gpiolib to just swallow all quirks, so: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |