lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 066/241] vti4: ipip tunnel deregistration fixes.
    Date
    [ Upstream commit 5483844c3fc18474de29f5d6733003526e0a9f78 ]

    If tunnel registration failed during module initialization, the module
    would fail to deregister the IPPROTO_COMP protocol and would attempt to
    deregister the tunnel.

    The tunnel was not deregistered during module-exit.

    Fixes: dd9ee3444014e ("vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel")
    Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ipv4/ip_vti.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/net/ipv4/ip_vti.c
    +++ b/net/ipv4/ip_vti.c
    @@ -648,9 +648,9 @@ static int __init vti_init(void)
    return err;

    rtnl_link_failed:
    - xfrm4_protocol_deregister(&vti_ipcomp4_protocol, IPPROTO_COMP);
    -xfrm_tunnel_failed:
    xfrm4_tunnel_deregister(&ipip_handler, AF_INET);
    +xfrm_tunnel_failed:
    + xfrm4_protocol_deregister(&vti_ipcomp4_protocol, IPPROTO_COMP);
    xfrm_proto_comp_failed:
    xfrm4_protocol_deregister(&vti_ah4_protocol, IPPROTO_AH);
    xfrm_proto_ah_failed:
    @@ -666,6 +666,7 @@ pernet_dev_failed:
    static void __exit vti_fini(void)
    {
    rtnl_link_unregister(&vti_link_ops);
    + xfrm4_tunnel_deregister(&ipip_handler, AF_INET);
    xfrm4_protocol_deregister(&vti_ipcomp4_protocol, IPPROTO_COMP);
    xfrm4_protocol_deregister(&vti_ah4_protocol, IPPROTO_AH);
    xfrm4_protocol_deregister(&vti_esp4_protocol, IPPROTO_ESP);

    \
     
     \ /
      Last update: 2019-06-09 19:13    [W:4.180 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site