lkml.org 
[lkml]   [2019]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 1/6] ASoC: core: add support to snd_soc_dai_get_sdw_stream()
From
Date
On 2019-06-07 10:56, Srinivas Kandagatla wrote:
> On platforms which have smart speaker amplifiers connected via
> soundwire and modeled as aux devices in ASoC, in such usecases machine
> driver should be able to get sdw master stream from dai so that it can
> use the runtime stream to setup slave streams.
>
> soundwire already as a set function, get function would provide more
> flexibility to above configurations.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> include/sound/soc-dai.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
> index f5d70041108f..9f90b936fd9a 100644
> --- a/include/sound/soc-dai.h
> +++ b/include/sound/soc-dai.h
> @@ -177,6 +177,7 @@ struct snd_soc_dai_ops {
>
> int (*set_sdw_stream)(struct snd_soc_dai *dai,
> void *stream, int direction);
> + void *(*get_sdw_stream)(struct snd_soc_dai *dai, int direction);
> /*
> * DAI digital mute - optional.
> * Called by soc-core to minimise any pops.
> @@ -385,4 +386,13 @@ static inline int snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai,
> return -ENOTSUPP;
> }
>
> +static inline void *snd_soc_dai_get_sdw_stream(struct snd_soc_dai *dai, int direction)

Exceeds character limit?

> +{
> + if (dai->driver->ops->get_sdw_stream)
> + return dai->driver->ops->get_sdw_stream(dai, direction);
> + else
> + return NULL;

set_ equivalent returns -ENOTSUPP instead.
ERR_PTR seems to make more sense here.

> +

Unnecessary newline.

> +}
> +
> #endif
>

\
 
 \ /
  Last update: 2019-06-08 21:22    [W:0.145 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site