lkml.org 
[lkml]   [2019]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.1 01/70] iio: adc: ads124: avoid buffer overflow
    Date
    From: Vincent Stehlé <vincent.stehle@laposte.net>

    [ Upstream commit 0db8aa49a97e7f40852a64fd35abcc1292a7c365 ]

    When initializing the priv->data array starting from index 1, there is one
    less element to consider than when initializing the full array.

    Fixes: e717f8c6dfec8f76 ("iio: adc: Add the TI ads124s08 ADC code")
    Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
    Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
    Reviewed-by: Dan Murphy <dmurphy@ti.com>
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/adc/ti-ads124s08.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
    index 53f17e4f2f23..552c2be8d87a 100644
    --- a/drivers/iio/adc/ti-ads124s08.c
    +++ b/drivers/iio/adc/ti-ads124s08.c
    @@ -202,7 +202,7 @@ static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan)
    };

    priv->data[0] = ADS124S08_CMD_RDATA;
    - memset(&priv->data[1], ADS124S08_CMD_NOP, sizeof(priv->data));
    + memset(&priv->data[1], ADS124S08_CMD_NOP, sizeof(priv->data) - 1);

    ret = spi_sync_transfer(priv->spi, t, ARRAY_SIZE(t));
    if (ret < 0)
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-06-08 13:56    [W:8.781 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site