lkml.org 
[lkml]   [2019]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers/ata: print trim features at device initialization
From
Date

Konstantin,

> + if (dev->horkage & ATA_HORKAGE_NOTRIM)
> + trim_status = "backlisted";

blacklisted

> + else
> + trim_status = "supported";
> +
> + if (!ata_fpdma_dsm_supported(dev))
> + trim_queued = "no";
> + else if (dev->horkage & ATA_HORKAGE_NO_NCQ_TRIM)
> + trim_queued = "backlisted";

ditto

> + else
> + trim_queued = "yes";

Why is trim_status "supported" and trim_queued/trim_zero "yes"?

> +
> + if (!ata_id_has_zero_after_trim(id))
> + trim_zero = "no";
> + else if (dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM)
> + trim_zero = "yes";
> + else
> + trim_zero = "maybe";
> +
> + ata_dev_info(dev, "trim: %s, queued: %s, zero_after_trim: %s\n",
> + trim_status, trim_queued, trim_zero);
> + }
> +

Otherwise no particular objections. We were trying to limit noise during
boot which is why this information originally went to sysfs instead of
being printed during probe.

--
Martin K. Petersen Oracle Linux Engineering

\
 
 \ /
  Last update: 2019-06-07 19:01    [W:0.083 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site