Messages in this thread | | | Subject | Re: [PATCH v4 15/15] drm/bridge: tc358767: Replace magic number in tc_main_link_enable() | From | Andrzej Hajda <> | Date | Fri, 7 Jun 2019 08:42:02 +0200 |
| |
On 07.06.2019 06:45, Andrey Smirnov wrote: > We don't need 8 byte array, DP_LINK_STATUS_SIZE (6) should be > enough. This also gets rid of a magic number as a bonus. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
-- Regards Andrzej > Cc: Andrzej Hajda <a.hajda@samsung.com> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Andrey Gusakov <andrey.gusakov@cogentembedded.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Cory Tusar <cory.tusar@zii.aero> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/bridge/tc358767.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > index 4a245144aa83..05c5fab011f8 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -874,7 +874,7 @@ static int tc_main_link_enable(struct tc_data *tc) > u32 dp_phy_ctrl; > u32 value; > int ret; > - u8 tmp[8]; > + u8 tmp[DP_LINK_STATUS_SIZE]; > > dev_dbg(tc->dev, "link enable\n"); >
| |