Messages in this thread | | | Date | Fri, 7 Jun 2019 17:57:31 +0200 | From | Greg KH <> | Subject | Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl |
| |
On Fri, Jun 07, 2019 at 10:58:34AM +0000, Dragan Cvetic wrote: > > On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > > > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > > > +{ > > > + return 0; > > > +} > > > + > > > +static int xsdfec_dev_release(struct inode *iptr, struct file *fptr) > > > +{ > > > + return 0; > > > +} > > > > empty open/close functions are never needed, just drop them. > > > > open() is needed to allocate file descriptor eg. > fd = open(dev_name, O_RDWR);
But you do nothing in those open/release callbacks. Remove them and see that the code works just fine :)
thanks,
greg k-h
| |