Messages in this thread | | | Date | Fri, 7 Jun 2019 16:03:57 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH 06/18] drivers: firmware: psci: Support hierarchical CPU idle states |
| |
On Mon, May 13, 2019 at 09:22:48PM +0200, Ulf Hansson wrote: > From: Lina Iyer <lina.iyer@linaro.org> > > Currently CPU's idle states are represented in a flattened model, via the > "cpu-idle-states" binding from within the CPU's device nodes. > > Support the hierarchical layout, simply by converting to calling the new OF > helper, of_get_cpu_state_node(). > > Suggested-by: Sudeep Holla <sudeep.holla@arm.com> > Signed-off-by: Lina Iyer <lina.iyer@linaro.org> > Co-developed-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes: > - None. > > --- > drivers/firmware/psci/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 9c2180bcee4c..b11560f7c4b9 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -316,7 +316,7 @@ static int psci_dt_cpu_init_idle(struct cpuidle_driver *drv, > return -ENOMEM; > > for (i = 0; i < num_state_nodes; i++) { > - state_node = of_parse_phandle(cpu_node, "cpu-idle-states", i); > + state_node = of_get_cpu_state_node(cpu_node, i);
Ah I spoke too early, it's introduced here. Can be part of earlier simplification patch, but I am fine either way.
-- Regards, Sudeep
| |