Messages in this thread | | | Date | Fri, 7 Jun 2019 17:18:55 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/2] staging: rtl8712: r8712_createbss_cmd(): Change |
| |
Fix the subject.
On Fri, Jun 07, 2019 at 07:36:58PM +0530, Nishka Dasgupta wrote: > Change return values of r8712_createbss_cmd from _SUCCESS and _FAIL to 0 > and -ENOMEM respectively. > Change return type of the function from unsigned to int to reflect this. > Change call site to check for 0 instead of _SUCCESS. > (Instead of !=0, simply passing the function output to the conditional ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > will do.) ^^^^^^^^^
Remove this line.
Otherwise it looks ok. Please resend.
regards, dan carpenter
| |