Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 6 Jun 2019 20:06:28 +0200 | Subject | Re: [PATCH 01/20] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation |
| |
Hi Jacopo,
On Thu, Jun 6, 2019 at 4:21 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on Gen2 and Gen3 SoCs (V3H and V3M excluded).
R-Car Gen2 ...
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks for your patch!
> index 000000000000..d8d3cf9ce2ce > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > @@ -0,0 +1,25 @@ > +* Renesas R-Car Color Management Module (CMM) > + > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > + > +Required properties: > + - compatible: shall be one of: > + - "renesas,cmm-gen3" > + - "renesas,cmm-gen2"
"gen3" and "gen2" don't carry much meaning on their own (SH2 is gen2 of SuperH?). Furthermore, revision info should immediately follow the comma.
"renesas,rcar-gen3-cmm" and "renesas,rcar-gen2-cmm"?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |