Messages in this thread | | | Subject | Re: [PATCH v2 5/7] clk: raspberrypi: register platform device for raspberrypi-cpufreq | From | Stephen Boyd <> | Date | Thu, 06 Jun 2019 10:20:52 -0700 |
| |
Quoting Nicolas Saenz Julienne (2019-06-06 10:16:56) > On Thu, 2019-06-06 at 10:05 -0700, Stephen Boyd wrote: > > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:58) > > > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk- > > > raspberrypi.c > > > index b1365cf19f3a..052296b5fbe4 100644 > > > --- a/drivers/clk/bcm/clk-raspberrypi.c > > > +++ b/drivers/clk/bcm/clk-raspberrypi.c > > > @@ -63,6 +63,8 @@ struct raspberrypi_firmware_prop { > > > __le32 disable_turbo; > > > } __packed; > > > > > > +static struct platform_device *rpi_cpufreq; > > > > Why can't this be stored in platform driver data? > > It actually could, I just followed the same pattern as the code found in patch > #3. I'll update it in the next version if you prefer it. >
Yes please. It reduces global state.
| |