Messages in this thread | | | Subject | Re: [PATCH] cpupower : frequency-set -r option misses the last cpu in related cpu list | From | shuah <> | Date | Tue, 4 Jun 2019 09:16:12 -0600 |
| |
On 5/29/19 8:21 AM, Thomas Renninger wrote: > Hi, > > On Wednesday, May 29, 2019 2:12:34 PM CEST Gautham R Shenoy wrote: >> Hi Abhishek, >> >> On Wed, May 29, 2019 at 3:02 PM Abhishek Goel > > ... > >>> bitmask_setbit(cpus_chosen, cpus->cpu); >>> cpus = cpus->next; >>> >>> } >>> >>> + /* Set the last cpu in related cpus list */ >>> + bitmask_setbit(cpus_chosen, cpus->cpu); >> >> Perhaps you could convert the while() loop to a do .. while(). That >> should will ensure >> that we terminate the loop after setting the last valid CPU. > > It would do exactly the same, right? > IMHO it's not worth the extra hassle of resubmitting. Setting the last value > outside a while loop is rather common. > > I do not have a CPU with related cores at hand. > If you tested this it would be nice to see this pushed: > > Reviewed-by: Thomas Renninger <trenn@suse.de> >
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/ cpupower branch.
thanks, -- Shuah
| |