Messages in this thread | | | Subject | RE:(2) [PATCH 1/4] zstd: pass pointer rathen than structure to functions | From | Vaneet Narang <> | Date | Tue, 04 Jun 2019 18:49:35 +0530 |
| |
Hi Andrew, >But struct ZSTD_CCtx_s.params is still a copied structure. Could we >make it `const ZSTD_parameters *params'? Probably not, due to lifetime >issues?
ZSTD maintains its own ctxt. Yes we can avoid storing pointers of other modules because of lifetime issues. We should keep ZSTD_CCtx_s.params as structure instead of pointer.
Thanks & Regards, Vaneet Narang
| |