Messages in this thread | | | Subject | Re: [PATCH] KVM: arm64: Drop 'const' from argument of vq_present() | From | Marc Zyngier <> | Date | Tue, 4 Jun 2019 10:01:25 +0100 |
| |
On 04/06/2019 09:43, Catalin Marinas wrote: > On Tue, Jun 04, 2019 at 10:13:19AM +0530, Viresh Kumar wrote: >> We currently get following compilation warning: >> >> arch/arm64/kvm/guest.c: In function 'set_sve_vls': >> arch/arm64/kvm/guest.c:262:18: warning: passing argument 1 of 'vq_present' from incompatible pointer type >> arch/arm64/kvm/guest.c:212:13: note: expected 'const u64 (* const)[8]' but argument is of type 'u64 (*)[8]' > > Since the vq_present() function does not modify the vqs array, I don't > understand why this warning. Compiler bug?
Yeah, I'm a bit puzzled by that one. Also checked with clang, which is usually much more picky about things, but it didn't complain.
We could drop the const without much harm, but I really wish we weed out these ancient compilers...
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |