lkml.org 
[lkml]   [2019]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] media: cedrus: Disable engine after each slice decoding
    Hi,

    On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote:
    > libvdpau-sunxi always disables engine after each decoded slice.
    > Do same in Cedrus driver.
    >
    > Presumably this also lowers power consumption which is always nice.
    >
    > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

    Is it fixing anything though?

    I indeed saw that cedar did disable it everytime, but I couldn't find
    a reason why.

    Also, the power management improvement would need to be measured, it
    can even create the opposite situation where the device will draw more
    current from being woken up than if it had just remained disabled.

    Maxime

    --
    Maxime Ripard, Bootlin
    Embedded Linux and Kernel engineering
    https://bootlin.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-06-03 13:39    [W:2.902 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site