Messages in this thread | | | Date | Fri, 28 Jun 2019 17:12:26 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] devres: allow const resource arguments |
| |
On Fri, Jun 28, 2019 at 04:59:45PM +0200, Arnd Bergmann wrote: > devm_ioremap_resource() does not currently take 'const' arguments, > which results in a warning from the first driver trying to do it > anyway: > > drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe': > drivers/gpio/gpio-amd-fch.c:171:49: error: passing argument 2 of 'devm_ioremap_resource' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores); > ^~~~~~~~~~~~~~~~~~~ > > Change the prototype to allow it, as there is no real reason not to. > > Fixes: 9bb2e0452508 ("gpio: amd: Make resource struct const") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > The warning is currently in Linus Walleij's gpio tree, so I would > suggest he can queue up this fix as well, if Greg (or whoever > feels responsible for devres) agrees.
That's fine with me if Linus takes it:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |