Messages in this thread Patch in this message | | | From | Andi Kleen <> | Subject | [PATCH 3/3] perf tools metric: Don't include duration_time in group | Date | Fri, 28 Jun 2019 15:07:37 -0700 |
| |
From: Andi Kleen <ak@linux.intel.com>
The Memory_BW metric generates groups including duration_time, which maps to a software event.
For some reason this makes the group always not count.
Always put duration_time outside a group when generating metrics. It's always the same time, so no need to group it.
Signed-off-by: Andi Kleen <ak@linux.intel.com> --- tools/perf/util/metricgroup.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index 1c85c9624c58..17ec05e17e7b 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -410,6 +410,7 @@ static int metricgroup__add_metric(const char *metric, struct strbuf *events, const char **ids; int idnum; struct egroup *eg; + bool no_group = false; pr_debug("metric expr %s for %s\n", pe->metric_expr, pe->metric_name); @@ -420,11 +421,25 @@ static int metricgroup__add_metric(const char *metric, struct strbuf *events, strbuf_addf(events, ","); for (j = 0; j < idnum; j++) { pr_debug("found event %s\n", ids[j]); + /* + * Duration time maps to a software event and can make + * groups not count. Always use it outside a + * group. + */ + if (!strcmp(ids[j], "duration_time")) { + if (j > 0) + strbuf_addf(events, "}:W,"); + strbuf_addf(events, "duration_time"); + no_group = true; + continue; + } strbuf_addf(events, "%s%s", - j == 0 ? "{" : ",", + j == 0 || no_group ? "{" : ",", ids[j]); + no_group = false; } - strbuf_addf(events, "}:W"); + if (!no_group) + strbuf_addf(events, "}:W"); eg = malloc(sizeof(struct egroup)); if (!eg) { -- 2.20.1
| |