Messages in this thread | | | Date | Thu, 27 Jun 2019 05:11:58 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe() |
| |
Hi,
* Suman Anna <s-anna@ti.com> [190625 23:33]: > The clocks are not yet parsed and prepared until after a successful > sysc_get_clocks(), so there is no need to unprepare the clocks upon > any failure of any of the prior functions in sysc_probe(). The current > code path would have been a no-op because of the clock validity checks > within sysc_unprepare(), but let's just simplify the cleanup path by > returning the error directly. > > While at this, also fix the cleanup path for a sysc_init_resets() > failure which is executed after the clocks are prepared.
Sounds like this should get queued separately as a fix for v5.3-rc cycle, probably got broken with the recent ti-sysc init order changes.
Regards,
Tony
| |