Messages in this thread | | | From | Horia Geanta <> | Subject | Re: [PATCH v3 1/5] crypto: caam - move DMA mask selection into a function | Date | Thu, 27 Jun 2019 10:50:56 +0000 |
| |
On 6/17/2019 7:04 PM, Andrey Smirnov wrote: > Exactly the same code to figure out DMA mask is repeated twice in the > driver code. To avoid repetition, move that logic into a standalone > subroutine in intern.h. While at it re-shuffle the code to make it > more readable with early returns. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Chris Spencer <christopher.spencer@sea.co.uk> > Cc: Cory Tusar <cory.tusar@zii.aero> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Horia Geantă <horia.geanta@nxp.com> > Cc: Aymen Sghaier <aymen.sghaier@nxp.com> > Cc: Leonard Crestez <leonard.crestez@nxp.com> > Cc: linux-crypto@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Being the 1st patch in the series and not i.MX8-specific, I'd say it should be merged separately.
Thanks, Horia
| |