Messages in this thread | | | From | Jose Abreu <> | Subject | RE: [PATCH net-next 07/10] net: stmmac: Enable support for > 32 Bits addressing in XGMAC | Date | Thu, 27 Jun 2019 07:54:45 +0000 |
| |
From: Andrew Lunn <andrew@lunn.ch>
> > + > > + if (priv->dma_cap.addr64) { > > + ret = dma_set_mask_and_coherent(device, > > + DMA_BIT_MASK(priv->dma_cap.addr64)); > > + if (!ret) > > + dev_info(priv->device, "Using %d bits DMA width\n", > > + priv->dma_cap.addr64); > > + } > > Hi Jose > > If dma_set_mask_and_coherent() fails, i think you are supposed to fall > back to 32 bits. So you might want to clear priv->dma_cap.addr64.
Yeah, seems right. Thanks for pointing!
| |