lkml.org 
[lkml]   [2019]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 26/29] x86/hpet: Consolidate clockevent functions
On Wed, 26 Jun 2019, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
> > - evt->set_state_shutdown = hpet_msi_shutdown;
> > - evt->set_state_oneshot = hpet_msi_set_oneshot;
> > - evt->tick_resume = hpet_msi_resume;
> > - evt->set_next_event = hpet_msi_next_event;
> > + evt->set_state_shutdown = hpet_clkevt_shutdown;
> > + evt->set_state_oneshot = hpet_clkevt_set_oneshot;
> > + evt->set_next_event = hpet_clkevt_set_next_event;
> > + evt->tick_resume = hpet_clkevt_msi_resume;
> > evt->cpumask = cpumask_of(hc->cpu);
>
> My compulsive-obsessive half really wants this to look like:
>
> > + evt->set_state_shutdown = hpet_clkevt_shutdown;
> > + evt->set_state_oneshot = hpet_clkevt_set_oneshot;
> > + evt->set_next_event = hpet_clkevt_set_next_event;
> > + evt->tick_resume = hpet_clkevt_msi_resume;
> > evt->cpumask = cpumask_of(hc->cpu);

Just to remove all of that in the next patch again, which then has the
proper aligned thing to make you happy :)

> Also, maybe harmonize the callback names with the local function names,
> like hpet_clkevt_set_next_event() already does and
> hpet_clkevt_set_oneshot() almost does:
>
> s/hpet_clkevt_shutdown
> /hpet_clkevt_set_state_shutdown
>
> s/hpet_clkevt_set_oneshot
> /hpet_clkevt_set_state_oneshot
>
> s/hpet_clkevt_msi_resume
> /hpet_clkevt_tick_resume
>
> ... unless the name variations have some hidden purpose and meaning?

Historical but we want to preserve some of the old stuff for sentimental
reasons.

Thanks,

tglx

\
 
 \ /
  Last update: 2019-06-28 00:45    [W:0.061 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site