Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 26 Jun 2019 13:54:19 +0200 | Subject | Re: [PATCH v3] gpio: mockup: no need to check return value of debugfs_create functions |
| |
On Wed, Jun 26, 2019 at 10:46 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Bamvor Jian Zhang <bamv2005@gmail.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > [Bartosz: removed one more check for debugfs return value] > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > v1 -> v2: > - fix build warning found by kbuild > - fix build error found by kbuild > > v2 -> v3: > - remove one more unnecessary ifdef
Looks good Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Will you send me this in a pull request with the rest of the stuff you have queued?
Yours, Linus Walleij
| |