Messages in this thread | | | From | Schrempf Frieder <> | Subject | Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips | Date | Tue, 25 Jun 2019 12:04:58 +0000 |
| |
On 25.06.19 13:56, liaoweixiong wrote: > Oh, i am sorry that i had misunderstanded your letter.
No problem ;)
> Thank you for your document and guidance.
You're welcome!
> On 2019/6/25 PM 3:04, Schrempf Frieder wrote: >> Hi liaoweixiong, >> >> On 25.06.19 05:08, Greg KH wrote: >>> On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: >>>> In case of the last page containing bitflips (ret > 0), >>>> spinand_mtd_read() will return that number of bitflips for the last >>>> page. But to me it looks like it should instead return max_bitflips like >>>> it does when the last page read returns with 0. >>>> >>>> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com> >>>> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> >>>> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> >>>> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") >>>> --- >>>> drivers/mtd/nand/spi/core.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> <formletter> >>> >>> This is not the correct way to submit patches for inclusion in the >>> stable kernel tree. Please read: >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>> for how to do this properly. >>> >>> </formletter> >> >> FYI, you should not send the patch to stable@vger.kernel.org, but >> instead, as I said in my other reply, add the tag "Cc: >> stable@vger.kernel.org". See "Option 1" in the document Greg referred to. >> >> Thanks, >> Frieder >> > | |