lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/12] xfs: refactor the ioend merging code
    On Mon, Jun 24, 2019 at 07:06:22PM +0300, Nikolay Borisov wrote:
    > > +{
    > > + struct list_head tmp;
    > > +
    > > + list_replace_init(&ioend->io_list, &tmp);
    > > + xfs_destroy_ioend(ioend, error);
    > > + while ((ioend = list_pop(&tmp, struct xfs_ioend, io_list)))
    > > + xfs_destroy_ioend(ioend, error);
    >
    > nit: I'd prefer if the list_pop patch is right before this one since
    > this is the first user of it.

    I try to keep generic infrastructure first instead of interveawing
    it with subystem-specific patches.

    > Additionally, I don't think list_pop is
    > really a net-negative win

    What is a "net-negative win" ?

    > in comparison to list_for_each_entry_safe
    > here. In fact this "delete the list" would seems more idiomatic if
    > implemented via list_for_each_entry_safe

    I disagree. The for_each loops require an additional next iterator,
    and also don't clearly express what is going on, but require additional
    spotting of the list_del.

    \
     
     \ /
      Last update: 2019-06-25 12:15    [W:4.110 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site