lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] perf/x86/intel: Mark expected switch fall-throughs
    On Mon, Jun 24, 2019 at 03:53:04PM -0500, Gustavo A. R. Silva wrote:
    > Once the C++17 `__attribute__((fallthrough))` is more widely handled by C compilers,

    From what I read that attribute landed in the exact same GCC version as
    the warning. And last I checked clang wasn't there yet anyway.

    > static analyzers, and IDEs, we can switch to using that instead. Also, we are a few

    I don't give a crap about lousy IDEs. And coverity already supports the
    attribute and other checkers are open-source and can be easily fixed or
    ignored.

    > warnings away (less than five) from being able to enable -Wimplicit-fallthrough. After
    > this option has been finally enabled (in v5.3) we can easily go and replace the comments
    > to whatever we agree upon.

    Feh. Still an abomination.

    \
     
     \ /
      Last update: 2019-06-25 09:16    [W:2.130 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site