Messages in this thread | | | Date | Tue, 25 Jun 2019 18:50:39 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2 0/3] ceph: don't NULL terminate virtual xattr values |
| |
On Thu, 20 Jun 2019 09:54:13 -0400 Jeff Layton <jlayton@kernel.org> wrote:
> > snprintf() to a temporary buffer, and memcpy() to the final destination. > > These are all fairly small buffers (most are single integer values), > > so the overhead should be minimal, right? > > > > Yeah. I was trying to avoid having to deal with a second buffer, but > this is not a performance-critical codepath, so maybe that's the best > option.
Yes, this looks like the better solution than adding a new library function for other people to (ab)use.
-- Steve
| |