Messages in this thread | | | Date | Mon, 24 Jun 2019 13:51:26 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] pinctrl: qcom: sdm845: Fix CONFIG preprocessor guard |
| |
On Fri, 21 Jun 2019, Nick Desaulniers wrote:
> On Fri, Jun 21, 2019 at 1:21 PM Nathan Chancellor > <natechancellor@gmail.com> wrote: > > > > Clang warns when CONFIG_ACPI is unset: > > > > drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is > > not defined, evaluates to 0 [-Wundef] > > #if CONFIG_ACPI > > ^ > > 1 warning generated. > > > > Use ifdef instead of if to resolve this. > > > > Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support") > > Link: https://github.com/ClangBuiltLinux/linux/issues/569 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > Thanks for the patch. > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Interesting. Thanks for fixing.
Acked-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |