Messages in this thread | | | Date | Mon, 24 Jun 2019 12:03:39 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH][next] clocksource: davinci-timer: fix memory leak of clockevent on error return |
| |
On Mon, Jun 24, 2019 at 10:28:10AM +0200, Bartosz Golaszewski wrote: > pon., 17 cze 2019 o 13:31 Colin King <colin.king@canonical.com> napisał(a): > > > > From: Colin Ian King <colin.king@canonical.com> > > > > Currently when the call to request_irq falls there is a memory leak of > > clockevent on the error return path. Fix this by kfree'ing clockevent. > > > > Addresses-Coverity: ("Resource leak") > > Fixes: fe3b8194f274 ("clocksource: davinci-timer: add support for clockevents") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/clocksource/timer-davinci.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c > > index a9ca02390b66..8512f12e250a 100644 > > --- a/drivers/clocksource/timer-davinci.c > > +++ b/drivers/clocksource/timer-davinci.c > > @@ -300,6 +300,7 @@ int __init davinci_timer_register(struct clk *clk, > > "clockevent/tim12", clockevent); > > if (rv) { > > pr_err("Unable to request the clockevent interrupt"); > > + kfree(clockevent); > > return rv; > > } > > > > -- > > 2.20.1 > > > > Hi Colin, > > I omitted the error checking in this driver on purpose - it doesn't > make sense as the system won't boot without a timer.
One way to silence these static checker warnings is to use "GFP_KERNEL | __GFP_NOFAIL".
regards, dan carpenter
| |