Messages in this thread | | | Subject | Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource() | From | "Enrico Weigelt, metux IT consult" <> | Date | Mon, 24 Jun 2019 20:22:45 +0200 |
| |
On 24.06.19 12:46, Bartosz Golaszewski wrote:
>> The patch seems pretty trivial and doesn't change any actual code, so >> I don't see hard resons for rejecting it. >> > > In its current form it makes the code even less readable. The #ifdef > should actually be one line lower and touch the comment instead of the > EXPORT_SYMBOL() related to a different function.
Okay, that missing newline should be fixed (as well as the extra one after the #ifdef). Besides that, I don't see any further problems.
--mtx
-- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |